Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigning the search bar #5172

Closed
wants to merge 3 commits into from
Closed

Redesigning the search bar #5172

wants to merge 3 commits into from

Conversation

divyabaid16
Copy link
Contributor

From pull request #5121

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Fixed the issue in Google Chrome.
Selection_079

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 19, 2019 •
edited
Loading

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@grvsachdeva
Copy link
Member

Google chrome view of page when I ran this PR
Screenshot from 2019-03-19 18-46-07

The thing in discussion at #5121 is the width of search bar right?

@divyabaid16
Copy link
Contributor Author

@gauravano
I had set the minimun width to 270 px.
So I think that size of the search bar should increase.

@divyabaid16
Copy link
Contributor Author

The thing in discussion at #5121 is the width of search bar right?

@gauravano Yes.

@grvsachdeva
Copy link
Member

I think it's fine to have the current size too? Let's try by adding 50/60 px more, but yes see mobile-view too along the changes. Thanks @divyabaid16

@jywarren jywarren mentioned this pull request Mar 19, 2019
Closed
5 tasks
@divyabaid16
Copy link
Contributor Author

@gauravano when I decrease the screen size upto the size of mobile view, 270px is the maximum value that can be allowed that is compatible with the small screen.

@divyabaid16
Copy link
Contributor Author

after the change, the gif that is getting is as follows @gauravano @jywarren
Peek 2019-03-20 17-43

@jywarren
Copy link
Member

Hi! just chiming in to mention that several related changes were merged, so we'll need to be sure this works on top of those changes:

https://publiclab.org/tags

It's looking great! Thank you!

@divyabaid16
Copy link
Contributor Author

@jywarren Now the changes are in sync with the master branch.

@SidharthBansal
Copy link
Member

There are some conflicts in your pr. It will be great if you can rebase your pr.
Thanks for the work done here at PL

@divyabaid16
Copy link
Contributor Author

I will do it very soon @SidharthBansal
Thanks!

@divyabaid16
Copy link
Contributor Author

Hi!!!
This issue has been fixed in the PR #5483 by @gautamig54 hence I'm closing it down.
Thanks!

@grvsachdeva
Copy link
Member

Ok. Thanks @divyabaid16!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyabaid16 @plotsbot @grvsachdeva @jywarren @SidharthBansal